RFR: 7903659 Verify Problemlist contents
Jonathan Gibbons
jjg at openjdk.org
Wed Mar 6 23:47:02 UTC 2024
On Fri, 9 Feb 2024 20:07:20 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:
> This change introduces the flag `--excludeverify` which will run additional checks on the problemlists passes through `-exclude`. If any of the checks fails, jtreg prints a helpful message and refuses to start running tests.
test/excludeverify/ExcludeVerifyTest.gmk line 2:
> 1: #
> 2: # Copyright (c) 2012, 2022, Oracle and/or its affiliates. All rights reserved.
Year should probably be 2024
test/excludeverify/ExcludeVerifyTest.gmk line 149:
> 147: $(BUILDTESTDIR)/excludeverify.good.ok \
> 148: $(BUILDTESTDIR)/excludeverify.id.ok \
> 149: $(BUILDTESTDIR)/excludeverify.exist.ok
Overall general comment for the file:
Well done; you did good!
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/181#discussion_r1515292846
PR Review Comment: https://git.openjdk.org/jtreg/pull/181#discussion_r1515293147
More information about the jtreg-dev
mailing list