RFR: 7903659 Verify Problemlist contents

Jonathan Gibbons jjg at openjdk.org
Wed Mar 6 23:57:01 UTC 2024


On Fri, 9 Feb 2024 20:07:20 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:

> This change introduces the flag `--excludeverify` which will run additional checks on the problemlists passes through `-exclude`. If any of the checks fails, jtreg prints a helpful message and refuses to start running tests.

test/excludeverify/ExcludeVerifyTest.gmk line 45:

> 43: 		|| (exit 0)
> 44: 	$(GREP) -s "Must follow:" $(@:%.ok=%/log 2>&1)
> 45: 	$(GREP) -s "The fully qualified test must exists." $(@:%.ok=%/log 2>&1) && exit 1 || exit 0

Here and on similar lines, the appearance of `2>&1` _inside_ the `$(@...)` expression seems weird to the point of wrong.  I don't know what you're trying to do of if any redirection is actually necessary here. If you copied this code from elsewhere, I'd be interested to know where from.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/181#discussion_r1515298810


More information about the jtreg-dev mailing list