RFR: 7903659 Verify Problemlist contents [v5]

[Ludvig Janiuk]

On Fri, 8 Mar 2024 15:55:27 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:

>> test/excludeverify/ExcludeVerifyTest.gmk line 45:
>> 
>>> 43: 		|| (exit 0)
>>> 44: 	$(GREP) -s "Must follow:" $(@:%.ok=%/log 2>&1)
>>> 45: 	$(GREP) -s "The fully qualified test must exists." $(@:%.ok=%/log 2>&1) && exit 1 || exit 0
>> 
>> Here and on similar lines, the appearance of `2>&1` _inside_ the `$(@...)` expression seems weird to the point of wrong.  I don't know what you're trying to do or if any redirection is actually necessary here. If you copied this code from elsewhere, I'd be interested to know where from.
>
> I'm pretty sure I copied from https://github.com/openjdk/jtreg/blob/master/test/exclude/ExcludeTest.gmk, the same pattern is found on https://github.com/openjdk/jtreg/blob/master/test/exclude/ExcludeTest.gmk#L44.

I am still not sure whether there's something wrong with these or not, but if there is, that other test should also be looked at.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/181#discussion_r1519471492