RFR: 7903659 Verify Problemlist contents [v5]
Jonathan Gibbons
jjg at openjdk.org
Mon Mar 11 21:39:25 UTC 2024
On Mon, 11 Mar 2024 10:13:44 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:
>> I'm pretty sure I copied from https://github.com/openjdk/jtreg/blob/master/test/exclude/ExcludeTest.gmk, the same pattern is found on https://github.com/openjdk/jtreg/blob/master/test/exclude/ExcludeTest.gmk#L44.
>
> I am still not sure whether there's something wrong with these or not, but if there is, that other test should also be looked at.
The code might work "by accident", but is for sure not how it is meant to be.
There are two parts to this expression:
1. `$(@:%.ok=%/log)`. This is an expression to generate a string from `$@` by replacing the trailing `.ok` with `/log` -- in other words, based on the name of the target `$@` generate a related name for the log file
2. `2>&1`. This is plain old shell redirection, and should be directly on the `grep` command line, and not hidden in. the `$(@:...)` expression.
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/181#discussion_r1520459918
More information about the jtreg-dev
mailing list