RFR: 7903443: Propagate verbose flag to agents [v2]
Jonathan Gibbons
jjg at openjdk.org
Tue May 28 20:39:16 UTC 2024
On Fri, 24 May 2024 10:23:24 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Please review this change to make `jtreg` propagate its verbosity configuration to agents.
>>
>> This pull request also updates the `JUnitRunner` agent to evaluate the verbosity configuration and act accordingly.
>> For example, passing `-v:nopass,error,fail` at the command line to `jtreg` will suppress the `STARTED: ...` and `SUCCESSFUL: ...` lines in `.jtr` files for JUnit-based tests.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>
> Update copyright year
src/share/classes/com/sun/javatest/regtest/agent/AgentVerbose.java line 40:
> 38: * @return DEFAULT or a verbose instance parsed from the input string
> 39: */
> 40: public static AgentVerbose ofStringRepresentation(String s) {
minor, it would be enough to use just `of`
src/share/classes/com/sun/javatest/regtest/tool/JarManager.java line 77:
> 75: InputStream in = getClass().getResourceAsStream("jars.properties");
> 76: if (in == null) {
> 77: throw new Error("Can't find jars.properties");
What's the reason for dropping this?
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/187#discussion_r1617856894
PR Review Comment: https://git.openjdk.org/jtreg/pull/187#discussion_r1617861476
More information about the jtreg-dev
mailing list