RFR: 7903813: Tag enablePreview with false should take precedence [v3]
Jonathan Gibbons
jjg at openjdk.org
Mon Sep 9 21:29:15 UTC 2024
On Mon, 9 Sep 2024 10:21:48 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Please review this change to let tests with `@enablePreview false` take precedence over libraries that require preview features being enabled.
>>
>> Note that the [PreviewHiddenClass](https://github.com/openjdk/jdk/blob/f6d7e30b84fedbf42077526610ba7a5bcfaece4c/test/jdk/java/lang/invoke/defineHiddenClass/PreviewHiddenClass.java#L34-L35) test should receive an explicit `enablePreview=false` tag line (in addition to the comment).
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>
> Add test for 7903813
Locally, some tests fail.
For example:
> make: *** [/Users/jjg/Work/jtreg/jtreg.dev/open/build/test/LibBuildArgsTest.good.ok] Error 1
-------------
PR Comment: https://git.openjdk.org/jtreg/pull/225#issuecomment-2339120075
More information about the jtreg-dev
mailing list