RFR: 7903813: Tag enablePreview with false should take precedence [v3]

[Jonathan Gibbons]

On Mon, 9 Sep 2024 10:21:48 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Please review this change to let tests with `@enablePreview false` take precedence over libraries that require preview features being enabled.
>> 
>> Note that the [PreviewHiddenClass](https://github.com/openjdk/jdk/blob/f6d7e30b84fedbf42077526610ba7a5bcfaece4c/test/jdk/java/lang/invoke/defineHiddenClass/PreviewHiddenClass.java#L34-L35) test should receive an explicit `enablePreview=false` tag line (in addition to the comment).
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add test for 7903813

You need the following additional two-line patch:
[patch.txt](https://github.com/user-attachments/files/16937030/patch.txt)


If you can't see that, look in `BuildAction.java`, line 315, change to generate two values: `-source`, `N`, instead of `--source=N`.  Note the single dash form for `-source`.  The `--source` form is a more recent form, and does not work for JDK 9, 10, 11.

With that one edit, I get:
> All (     274) selected tests completed successfully

Maybe you can change the GHA tests to use JDK 11 for tests.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/225#issuecomment-2339229837