RFR: 7903961: Make default timeout configurable
Jaikiran Pai
jpai at openjdk.org
Tue Apr 1 09:27:33 UTC 2025
On Fri, 7 Mar 2025 10:45:30 GMT, Christian Stein <cstein at openjdk.org> wrote:
> Please review this change replacing the hard-coded `120` seconds default timeout for test actions with a configurable solution parsing a custom default value from `TEST.ROOT` and `TEST.properties` files:
>
>
> timeout.default.seconds=360
>
>
> Especially in combination with "JUnit.dirs" and "TestNG.dirs", where all actions directives found in a test file are ignored, is helpful.
src/share/classes/com/sun/javatest/regtest/config/TestProperties.java line 280:
> 278:
> 279: // add the default test timeout value in seconds
> 280: defaultTimeout = Duration.ofSeconds(getInt("timeout.default.seconds", 120));
Hello Christian, the `TEST.ROOT` (and `TEST.properties`) appear to follow the camel case style property names for most of the configurations https://openjdk.org/jtreg/tag-spec.html#TEST_ROOT. For example, `defaultExecMode`, `maxOutputSize` and so on. To be consistent with that, maybe we should expect this to be `defaultTimeoutSeconds` instead of `timeout.default.seconds`?
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/253#discussion_r2022491051
More information about the jtreg-dev
mailing list