RFR: 7903961: Make default timeout configurable
Jaikiran Pai
jpai at openjdk.org
Tue Apr 1 09:32:37 UTC 2025
On Mon, 10 Mar 2025 17:41:00 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Please review this change replacing the hard-coded `120` seconds default timeout for test actions with a configurable solution parsing a custom default value from `TEST.ROOT` and `TEST.properties` files:
>>
>>
>> timeout.default.seconds=360
>>
>>
>> Especially in combination with "JUnit.dirs" and "TestNG.dirs", where all actions directives found in a test file are ignored, is helpful.
>
> src/share/classes/com/sun/javatest/regtest/exec/RegressionScript.java line 1131:
>
>> 1129: Map<String, String> getTestProperties() {
>> 1130: // initialize the properties with standard properties common to all tests
>> 1131: Map<String, String> p = new TreeMap<>(params.getBasicTestProperties());
>
> This change sorts all basic test properties by their name; keeping the insertion order was never a promise.
Does the new proposed feature of configuring a default timeout continue to work without this change to using a `TreeMap`? If yes, then I think it would be good to separate this change out from this PR.
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/253#discussion_r2022499196
More information about the jtreg-dev
mailing list