RFR: 7904122: Compilation of jasm files leads to class file version warning
Christian Stein
cstein at openjdk.org
Fri Dec 12 09:11:32 UTC 2025
On Fri, 12 Dec 2025 07:39:47 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this change which fixes the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904122?
>
> The commit here adds `-cv 52.0` as an option when launching the `jasm` tool for compiling `jasm` files through jtreg's `@compile` action. This class file version will be used as the default version if the jasm file doesn't explicitly specify a class file version in it. The use of "-cv" option prevents the warning from being issued.
>
> An existing self test has been updated to verify this change.
test/jasm/Jasm.gmk line 45:
> 43: $(GREP) '\---jasm:' $(@:%.ok=%)/work/JasmUsageTest.jtr > /dev/null
> 44: # verify that the warning wasn't printed
> 45: $(GREP) 'Warning: Class file version not specified in file or by -cv parameter' \
Would it make sense to (also) look for any other "Warning: ..." messages? 🤔
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/303#discussion_r2613477749
More information about the jtreg-dev
mailing list