RFR: 7904122: Compilation of jasm files leads to class file version warning

[Jaikiran Pai]

On Fri, 12 Dec 2025 09:08:41 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Can I please get a review of this change which fixes the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904122?
>> 
>> The commit here adds `-cv 52.0` as an option when launching the `jasm` tool for compiling `jasm` files through jtreg's `@compile` action. This class file version will be used as the default version if the jasm file doesn't explicitly specify a class file version in it. The use of "-cv" option prevents the warning from being issued.
>> 
>> An existing self test has been updated to verify this change.
>
> test/jasm/Jasm.gmk line 45:
> 
>> 43: 	$(GREP) '\---jasm:' $(@:%.ok=%)/work/JasmUsageTest.jtr > /dev/null
>> 44: 	# verify that the warning wasn't printed
>> 45: 	$(GREP) 'Warning: Class file version not specified in file or by -cv parameter' \
> 
> Would it make sense to (also) look for any other "Warning: ..." messages? 🤔

Hello Christian, I wouldn't expect any other warning message and if there is one, I think we shouldn't allow that warning to fail this test. This test is merely interested in verifying that the class file version check warning message is not logged.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/303#discussion_r2613495138