RFR: 7904122: Compilation of jasm files leads to class file version warning
Christian Stein
cstein at openjdk.org
Fri Dec 12 09:23:33 UTC 2025
On Fri, 12 Dec 2025 09:14:24 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> test/jasm/Jasm.gmk line 45:
>>
>>> 43: $(GREP) '\---jasm:' $(@:%.ok=%)/work/JasmUsageTest.jtr > /dev/null
>>> 44: # verify that the warning wasn't printed
>>> 45: $(GREP) 'Warning: Class file version not specified in file or by -cv parameter' \
>>
>> Would it make sense to (also) look for any other "Warning: ..." messages? 🤔
>
> Hello Christian, I wouldn't expect any other warning message and if there is one, I think we shouldn't allow that warning to fail this test. This test is merely interested in verifying that the class file version check warning message is not logged.
Okay.
Yet, with such a broader assertion, we would have caught the issue with compiling `.jasm` files earlier.
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/303#discussion_r2613513196
More information about the jtreg-dev
mailing list