RFR: 7903920: Support building jtreg on FreeBSD

Fri Jan 24 20:49:35 UTC 2025

On Sat, 14 Dec 2024 10:48:09 GMT, snake66 <duke at openjdk.org> wrote:

> On FreeBSD we need to use GNU gmake instead of the BSD make program.

make/Defs.gmk line 145:

> 143: FIND	= /usr/bin/find
> 144: ifeq ($(SYSTEM_UNAME), FreeBSD)
> 145: GREP  := $(shell if [ -r /usr/local/bin/ggrep ]; then \

Maybe consider using ``which ggrep`` instead?

make/Defs.gmk line 186:

> 184: TOUCH 	= /usr/bin/touch
> 185: ifeq ($(SYSTEM_UNAME), FreeBSD)
> 186: UNZIP	= /usr/local/bin/unzip

Once again, maybe use `which` instead? Unless you have two installations of unzip, and the one in /usr/bin is broken in some way. Then you might need to check for brokenness instead.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/237#discussion_r1923644697
PR Review Comment: https://git.openjdk.org/jtreg/pull/237#discussion_r1923646156