RFR: 7903920: Support building jtreg on FreeBSD

snake66 duke at openjdk.org
Fri Jan 24 20:49:35 UTC 2025


On Tue, 21 Jan 2025 12:30:24 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> On FreeBSD we need to use GNU gmake instead of the BSD make program.
>
> make/Defs.gmk line 145:
> 
>> 143: FIND	= /usr/bin/find
>> 144: ifeq ($(SYSTEM_UNAME), FreeBSD)
>> 145: GREP  := $(shell if [ -r /usr/local/bin/ggrep ]; then \
> 
> Maybe consider using ``which ggrep`` instead?

Wouldn't this pretty much just be the same as just not specifying the path at all, and let the shell find it in $PATH? Which was [one of the complaints](https://github.com/openjdk/jtreg/pull/237#issuecomment-2543058251) against my first patch.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/237#discussion_r1927529089


More information about the jtreg-dev mailing list