RFR: 7903920: Support building jtreg on FreeBSD
Magnus Ihse Bursie
ihse at openjdk.org
Fri Jan 24 20:49:35 UTC 2025
On Thu, 23 Jan 2025 18:52:57 GMT, snake66 <duke at openjdk.org> wrote:
>> make/Defs.gmk line 145:
>>
>>> 143: FIND = /usr/bin/find
>>> 144: ifeq ($(SYSTEM_UNAME), FreeBSD)
>>> 145: GREP := $(shell if [ -r /usr/local/bin/ggrep ]; then \
>>
>> Maybe consider using ``which ggrep`` instead?
>
> Wouldn't this pretty much just be the same as just not specifying the path at all, and let the shell find it in $PATH? Which was [one of the complaints](https://github.com/openjdk/jtreg/pull/237#issuecomment-2543058251) against my first patch.
Okay, people have apparently varying opinions on this. :) Don't want to put you in a "damned if you do, damned if you don't" situation, so just ignore my comment and go with your solution.
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/237#discussion_r1927605137
More information about the jtreg-dev
mailing list