RFR: 7903931: Add "test.thread.factory" property to filter tests based on test thread factory value [v3]

Christian Stein cstein at openjdk.org
Thu Jan 30 09:12:02 UTC 2025


On Tue, 28 Jan 2025 17:47:33 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> jtreg support test thread factory parameter that allows to execute tests by running main in virtual thread.
>> 
>> Currently, all incompatible tests are problemlisted. However after security manager removal the number of such tests is small.
>> 
>> So is it makes sense to add "jtreg.ttf" property to filter tests based on test thread factory value to allow filter out incompatible tests.
>> 
>> The only jtreg knows if -testThreadFactory is set so it should set corresponding property
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   test.thread.factory is not a property for tag spec

src/share/classes/com/sun/javatest/regtest/config/RegressionContext.java line 105:

> 103: 
> 104:         String testThreadFactory = (params == null || params.getTestThreadFactory() == null)
> 105:                 ? "null"

Having `null` as the value for "no test thread factory available" is right choice regarding easier handling on the use-site?

Or would skipping the `values.put()` call be a better default? 🤔

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/242#discussion_r1935254685


More information about the jtreg-dev mailing list