RFR: 7903931: Add "test.thread.factory" property to filter tests based on test thread factory value [v3]

Leonid Mesnik lmesnik at openjdk.org
Thu Jan 30 17:49:05 UTC 2025


On Thu, 30 Jan 2025 09:09:26 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test.thread.factory is not a property for tag spec
>
> src/share/classes/com/sun/javatest/regtest/config/RegressionContext.java line 105:
> 
>> 103: 
>> 104:         String testThreadFactory = (params == null || params.getTestThreadFactory() == null)
>> 105:                 ? "null"
> 
> Having `null` as the value for "no test thread factory available" is right choice regarding easier handling on the use-site?
> 
> Or would skipping the `values.put()` call be a better default? 🤔

I haven't checked but it should be considered as a "invalid name" if we don't put any value.
Also, want to be consistent with other properties, that just have some default value, often "null".

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/242#discussion_r1936040967


More information about the jtreg-dev mailing list