RFR: 7904004: Run jtreg GHA workflows for FreeBSD [v2]
Christian Stein
cstein at openjdk.org
Wed May 7 10:54:39 UTC 2025
On Wed, 7 May 2025 10:47:22 GMT, snake66 <duke at openjdk.org> wrote:
>> GitHub Actions does not natively support FreeBSD, so we use the vmactions/freebsd-vm action as a base to run the tests in a VM under an Ubuntu runner.
>>
>> This work is sponsored by The FreeBSD Foundation.
>
> snake66 has updated the pull request incrementally with one additional commit since the last revision:
>
> Split long line in workflow
.github/workflows/test.yml line 73:
> 71: sysctl hw.usermem
> 72: pw user add -n action -m
> 73: su action -c 'git config --global --add safe.directory /home/runner/work/jtreg/jtreg'
Looks much better now, thanks for splitting the line into three calls.
Can the hard-coded `/home/runner/work/jtreg/jtreg` path be replaced with some inline `pwd` evaluation? Would make it more future-proof if parent paths are changed.
.github/workflows/test.yml line 74:
> 72: pw user add -n action -m
> 73: su action -c 'git config --global --add safe.directory /home/runner/work/jtreg/jtreg'
> 74: su action -c 'bash make/build.sh --jdk /usr/local/openjdk21'
I assume that the hard-coded `/usr/local/openjdk21` is well-defined and stable for `pkg ... openjdk21 ...` calls. Or is there an environment variable (`JAVA_HOME`?) being set that can be read out and used here?
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/262#discussion_r2077354169
PR Review Comment: https://git.openjdk.org/jtreg/pull/262#discussion_r2077356931
More information about the jtreg-dev
mailing list