RFR: 7904004: Run jtreg GHA workflows for FreeBSD [v2]
snake66
duke at openjdk.org
Wed May 7 10:54:40 UTC 2025
On Wed, 7 May 2025 10:50:03 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> snake66 has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Split long line in workflow
>
> .github/workflows/test.yml line 73:
>
>> 71: sysctl hw.usermem
>> 72: pw user add -n action -m
>> 73: su action -c 'git config --global --add safe.directory /home/runner/work/jtreg/jtreg'
>
> Looks much better now, thanks for splitting the line into three calls.
>
> Can the hard-coded `/home/runner/work/jtreg/jtreg` path be replaced with some inline `pwd` evaluation? Would make it more future-proof if parent paths are changed.
Good point! I'll look into it. Should probably be able to use `$(pwd)` or something.
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/262#discussion_r2077356545
More information about the jtreg-dev
mailing list