RFR: 7904004: Run jtreg GHA workflows for FreeBSD [v2]
snake66
duke at openjdk.org
Wed May 7 11:42:28 UTC 2025
On Wed, 7 May 2025 10:51:58 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> snake66 has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Split long line in workflow
>
> .github/workflows/test.yml line 74:
>
>> 72: pw user add -n action -m
>> 73: su action -c 'git config --global --add safe.directory /home/runner/work/jtreg/jtreg'
>> 74: su action -c 'bash make/build.sh --jdk /usr/local/openjdk21'
>
> I assume that the hard-coded `/usr/local/openjdk21` is well-defined and stable for `pkg ... openjdk21 ...` calls. Or is there an environment variable (`JAVA_HOME`?) being set that can be read out and used here?
While it's technically possible to change the prefix from `/usr/local`, this is the default unless explicitly changed.
There are ways to get the path without hardcoding it, but I'm not sure it's worth the effort here:
% JAVAVM_DRYRUN=1 javavm 2>/dev/null |grep JAVA_HOME|cut -d '=' -f 2
/usr/local/openjdk21
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/262#discussion_r2077434056
More information about the jtreg-dev
mailing list