RFR 8081266: Tab completion shows static methods on instance variables

andrei.eremeev andrei.eremeev at oracle.com
Wed May 27 08:56:45 UTC 2015


Hi,

I am Ok with the SQE part of the review.

As for the fix, length of lines should not exceed 80/120 characters per 
line.
So, length of the line should reduced.

+    private final Predicate<Element> STATIC_ONLY = IS_STATIC.or(IS_PACKAGE). ...

Let's wait Jan/Robert response about logic of the fix.

Andrei

On 05/27/2015 09:53 AM, ShinyaYoshida wrote:
> Hi,
> Could you review my patch?
>
> I also hid static fields on that context.
>
> bugs:
> https://bugs.openjdk.java.net/browse/JDK-8081266
>
> webrev:
> http://cr.openjdk.java.net/~shinyafox/kulla/8081266/webrev.00/
>
> Regards,
> shinyafox(Shinya Yoshida)



More information about the kulla-dev mailing list