RFR 8081266: Tab completion shows static methods on instance variables
ShinyaYoshida
bitterfoxc at gmail.com
Wed May 27 13:00:21 UTC 2015
Hi Andrei,
Thank you for your review!
Certainly, that's too long. I've updated my patch to reduce the length:
http://cr.openjdk.java.net/~shinyafox/kulla/8081266/webrev.01/
Regards,
shinyafox(Shinya Yoshida)
2015-05-27 17:56 GMT+09:00 andrei.eremeev <andrei.eremeev at oracle.com>:
> Hi,
>
> I am Ok with the SQE part of the review.
>
> As for the fix, length of lines should not exceed 80/120 characters per
> line.
> So, length of the line should reduced.
>
> + private final Predicate<Element> STATIC_ONLY =
> IS_STATIC.or(IS_PACKAGE). ...
>
> Let's wait Jan/Robert response about logic of the fix.
>
> Andrei
>
>
> On 05/27/2015 09:53 AM, ShinyaYoshida wrote:
>
>> Hi,
>> Could you review my patch?
>>
>> I also hid static fields on that context.
>>
>> bugs:
>> https://bugs.openjdk.java.net/browse/JDK-8081266
>>
>> webrev:
>> http://cr.openjdk.java.net/~shinyafox/kulla/8081266/webrev.00/
>>
>> Regards,
>> shinyafox(Shinya Yoshida)
>>
>
>
More information about the kulla-dev
mailing list