RFR 8147515: JShell: Internationalize

Jan Lahoda jan.lahoda at oracle.com
Mon Apr 4 12:55:50 UTC 2016


Seems OK to me. Some small feedback below:

Feedback.java:
-unused imports

JShellTool.java:
-constructor - javadoc for @param prefs:
@param prefs preferences to use

-prefix(String s, String leading):
would be better to use System.getProperty("line.separator") instead of "\n"?

-Command: we could infer the helpKey from the command in most cases; but 
I am fine with the current state as well.

ToolLocaleMessageTest.java:
-the "jdk.jdeps/com.sun.tools.javap" in @modules is most probably not 
needed with the current toolbox.ToolBox

Jan

On 4.4.2016 09:26, Robert Field wrote:
> Bug:
>      https://bugs.openjdk.java.net/browse/JDK-8147515
>
> Webrev:
>      http://cr.openjdk.java.net/~rfield/8147515.webrev/
>
> Thanks,
> Robert
>


More information about the kulla-dev mailing list