RFR 8147515: JShell: Internationalize

[Robert Field]

On 04/04/16 05:55, Jan Lahoda wrote:
> Seems OK to me. Some small feedback below:
>
> Feedback.java:
> -unused imports

Removed

>
> JShellTool.java:
> -constructor - javadoc for @param prefs:
> @param prefs preferences to use

Changed

>
> -prefix(String s, String leading):
> would be better to use System.getProperty("line.separator") instead of 
> "\n"?

Done

>
> -Command: we could infer the helpKey from the command in most cases; 
> but I am fine with the current state as well.

Added constructor that computes the helpKey

>
> ToolLocaleMessageTest.java:
> -the "jdk.jdeps/com.sun.tools.javap" in @modules is most probably not 
> needed with the current toolbox.ToolBox

A bunch of tests have this, should be removed together.


Thanks!

-Robert

>
> Jan
>
> On 4.4.2016 09:26, Robert Field wrote:
>> Bug:
>>      https://bugs.openjdk.java.net/browse/JDK-8147515
>>
>> Webrev:
>>      http://cr.openjdk.java.net/~rfield/8147515.webrev/
>>
>> Thanks,
>> Robert
>>