RFR 8199193: jshell tool: Add support for preview features

[Robert Field]

On 04/23/18 09:14, Jonathan Gibbons wrote:
> You need @modules.    You may not need to export/open any internal 
> API, but you certainly need the presence of certain modules.

Thanks.

Since tests are generally run with the full JDK, they do not verify the 
correctness of the @modules tag.  Do we have a way to verify/generate 
the correct entries?  Without testing, won't these descend into 
meaningless cloning of @modules or missing @modules?

The tag spec:

    http://openjdk.java.net/jtreg/tag-spec.html

Does not document :open, ...

It is not documented, can it be assumed that dependencies of a module 
are included automatically?

-Robert


>
> -- Jon
>
>
> On 4/23/18 8:41 AM, Robert Field wrote:
>> On 04/23/18 00:51, Sundararajan Athijegannathan wrote:
>>
>>> * On the new ToolEnablePreviewTest:
>>>
>>> 1) do you need to build KullTesting for this test?
>>> 2) do you need those @module declarations for this test? Seems like 
>>> this test stays within public APIs.
>>
>> All the tool tests clone, probably excess, @modules.  And neither 
>> @build is, I believe, needed.
>>
>> I've changed the header to just:
>>
>>    /*
>>      * @test
>>      * @bug 8199193
>>      * @summary Tests for the --enable-preview option
>>      * @run testng ToolEnablePreviewTest
>>      */
>>
>>
>> New webrev, with only this header changed:
>>
>>     http://cr.openjdk.java.net/~rfield/8199193v1.webrev/
>>
>> Thanks,
>> Robert
>>
>>>
>>> -Sundar
>>>
>>> On 23/04/18, 12:10 AM, Robert Field wrote:
>>>> Please review....
>>>>
>>>> Bug:
>>>>
>>>>     https://bugs.openjdk.java.net/browse/JDK-8199193
>>>>
>>>> Webrev:
>>>>
>>>>     http://cr.openjdk.java.net/~rfield/8199193v0.webrev/
>>>>
>>>> Thanks,
>>>> Robert
>>>>
>>>>
>>
>