RFR 8199193: jshell tool: Add support for preview features

[Jonathan Gibbons]

Sundar,

Yes, you only need specify an internal package if the source code of the 
test directly references that package (e.g. in an import statement)

Informally,


jtreg
	module-info
	command line
@module m
	requires m;
	--add-module m
m/p:open
	opens p;
	--add-opens m/p=ALL-UNNAMED
m/p:+open
	exports p;
	--add-opens m/p=ALL-UNNAMED
--add-exports m/p=ALL-UNNAMED


-- Jon

On 4/23/18 9:32 AM, Sundararajan Athijegannathan wrote:
> To check the presence of jdk.jshell module? (to avoid running it when 
> that module is not present?). Even then we don't need it in the form 
> with internal package names, right?
>
> @modules jdk.jshell ?
>
> -Sundar
>
> On 23/04/18, 9:14 AM, Jonathan Gibbons wrote:
>> You need @modules.    You may not need to export/open any internal 
>> API, but you certainly need the presence of certain modules.
>>
>> -- Jon
>>
>>
>> On 4/23/18 8:41 AM, Robert Field wrote:
>>> On 04/23/18 00:51, Sundararajan Athijegannathan wrote:
>>>
>>>> * On the new ToolEnablePreviewTest:
>>>>
>>>> 1) do you need to build KullTesting for this test?
>>>> 2) do you need those @module declarations for this test? Seems like 
>>>> this test stays within public APIs.
>>>
>>> All the tool tests clone, probably excess, @modules.  And neither 
>>> @build is, I believe, needed.
>>>
>>> I've changed the header to just:
>>>
>>>    /*
>>>      * @test
>>>      * @bug 8199193
>>>      * @summary Tests for the --enable-preview option
>>>      * @run testng ToolEnablePreviewTest
>>>      */
>>>
>>>
>>> New webrev, with only this header changed:
>>>
>>>     http://cr.openjdk.java.net/~rfield/8199193v1.webrev/
>>>
>>> Thanks,
>>> Robert
>>>
>>>>
>>>> -Sundar
>>>>
>>>> On 23/04/18, 12:10 AM, Robert Field wrote:
>>>>> Please review....
>>>>>
>>>>> Bug:
>>>>>
>>>>>     https://bugs.openjdk.java.net/browse/JDK-8199193
>>>>>
>>>>> Webrev:
>>>>>
>>>>>     http://cr.openjdk.java.net/~rfield/8199193v0.webrev/
>>>>>
>>>>> Thanks,
>>>>> Robert
>>>>>
>>>>>
>>>
>>