RFR: 8224184: jshell got IOException at exiting with AIX

[Toshio 5 Nakamura]

Hi Jan, Robert,

Thank you for your kind support!

Toshio Nakamura

Robert Field <robert.field at oracle.com> wrote on 2019/06/13 02:16:24:

> From: Robert Field <robert.field at oracle.com>
> To: Jan Lahoda <jan.lahoda at oracle.com>, Toshio 5 Nakamura
> <TOSHIONA at jp.ibm.com>
> Cc: kulla-dev at openjdk.java.net
> Date: 2019/06/13 02:17
> Subject: [EXTERNAL] Re: RFR: 8224184: jshell got IOException at
> exiting with AIX
>
> Thanks Jan!
>
> Yes, please push.
>
> -Robert
>
>
> On 6/12/19 2:25 AM, Jan Lahoda wrote:
> > Looks good to me. Robert, I'll push tomorrow morning, unless you see a
> > problem in that.
> >
> > Thanks,
> >    Jan
> >
> > On 12. 06. 19 11:18, Toshio 5 Nakamura wrote:
> >> Hi Jan,
> >>
> >> Thank you so much for the great advice.
> >> I could create a testcase for the issue.
> >>
> >> Could you re-review the patch?
> >>
https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Etnakamura_8224184_webrev.01_&d=DwID-g&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=K0TPg-JE9MCp7douy9-6UKxnD28-tZgttolS59yMNSg&s=KlCKJkypd37fyZkneyrpM-ujLlPGZWbJ0MkY5gAcA6k&e=

> >>
> >> Thanks,
> >> Toshio Nakamura
> >>
> >> Jan Lahoda <jan.lahoda at oracle.com> wrote on 2019/06/11 22:30:50:
> >>
> >>  > From: Jan Lahoda <jan.lahoda at oracle.com>
> >>  > To: Toshio 5 Nakamura <TOSHIONA at jp.ibm.com>, Robert Field
> >>  > <robert.field at oracle.com>
> >>  > Cc: kulla-dev at openjdk.java.net
> >>  > Date: 2019/06/11 22:31
> >>  > Subject: [EXTERNAL] Re: RFR: 8224184: jshell got IOException at
> >>  > exiting with AIX
> >>  >
> >>  > Hi Toshio,
> >>  >
> >>  > I think the change is fine, and I can sponsor the change.
> >>  >
> >>  > It might be possible to create a unit-like test by doing something
> >> like:
> >>  > class TestExecPty extends ExecPty {
> >>  >      public List<String> getFlagsToSet(Attributes attr, Attributes
> >>  > current) {
> >>  >          return super.getFlagsToSet(attr, current);
> >>  >      }
> >>  > }
> >>  >
> >>  > and then:
> >>  > new TestExecPty().getFlagsToSet(..., ...)
> >>  >
> >>  > with carefully prepared Attributes sent to the method. (Having this
> >>  > would help to ensure this does not break on updates of the
library.)
> >>  >
> >>  > Thanks,
> >>  >      Jan