RFR: 8200701 et. al. JShell: three source<-->wrapper position mapping issues

Jan Lahoda jan.lahoda at oracle.com
Fri Jun 14 18:05:56 UTC 2019


Looks OK to me.

Jan

On 13. 06. 19 20:31, Robert Field wrote:
> Please review --
> 
> Bugs:
> 
>    8200701: jdk/jshell/ExceptionsTest.java fails on Windows, after 
> JDK-8198801
> https://bugs.openjdk.java.net/browse/JDK-8200701
> 
>    8159740: JShell: corralled declarations do not have correct source to 
> wrapper mapping
> https://bugs.openjdk.java.net/browse/JDK-8159740
> 
>    8212167: JShell : Stack trace of exception has wrong line number
> https://bugs.openjdk.java.net/browse/JDK-8212167
> 
> Underlying causes:
> 
>    Corralled (recoverable undeclared definitions) declarations were 
> built from String rather than position translating wraps.
> 
>    Inconsistent exclusive/inclusive ends of ranges, range wraps, and 
> lookups.
> 
> Webrev:
> 
> http://cr.openjdk.java.net/~rfield/8200701v0.webrev/
> 
> 
> Thanks,
> Robert
> 
> 


More information about the kulla-dev mailing list