RFR: JDK-8264222: Use switch expression in jshell where possible [v2]

Fri Mar 26 23:50:24 UTC 2021

On Fri, 26 Mar 2021 22:07:22 GMT, Brian Goetz <briangoetz at openjdk.org> wrote:

>> Tagir F. Valeev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - resultTypeOf: update comment instead of splitting the case
>>  - resultTypeOf: split CONSTRUCTOR and INSTANCE_INIT/STATIC_INIT case to position the comments properly
>
> Cute trick for the partial update to `c`.  
> The comment in the last hunk (resultTypeOf()) only applied to the INSTANCE and STATIC init cases, but now it applies to CONSTRUCTOR too (in a previous hunk, you deliberately had a redundant case, to preserve this information.)   I would update the comment.
> 
> Otherwise, all looks good to me, +1.

@briangoetz thank you for review!

> I would update the comment.

I updated the comment and moved it before the case branch. Please take a look.

> Cute trick for the partial update to c.

Yeah, IDEA does this automatically!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3210