RFR: 8332314: Add window size configuration option to JavaShellToolBuilder interface

[Jan Lahoda]

On Tue, 14 May 2024 02:00:20 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> When launching JShell programmatically (i.e., from a Java program instead of the command line) for an interactive session, it's not currently possible to inform JShell what the terminal window's dimensions are. As a result, JShell defaults to 80x24 and line editing becomes almost impossible because of the scrambled screen contents unless you happen to be using an 80x24 window, which these days is very unlikely.
> 
> This patch adds a new method `JavaShellToolBuilder.windowSize()` which allows passing a "hint" for the number of rows & columns.

Makes sense to me. Please note the suggested change to `@since` inline.

src/jdk.jshell/share/classes/jdk/jshell/tool/JavaShellToolBuilder.java line 224:

> 222:      * @param rows number of displayed rows
> 223:      * @return the {@code JavaShellToolBuilder} instance
> 224:      * @since 23

Suggestion:

     * @since 24

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19226#pullrequestreview-2116036351
PR Review Comment: https://git.openjdk.org/jdk/pull/19226#discussion_r1638357582