RFR: 8341176: Permit access to diagnostics for transient snippets

[Vicente Romero]

On Mon, 30 Sep 2024 11:30:47 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> JShell permits to create transient snippets using `SourceCodeAnalysis.sourceToSnippets`, for the purpose of alternative UI clients. But, the alternative UI clients might need to get the diagnostics for the snippets, but the existing `JShell.diagnostics(Snippet)` will not work for the transient snippets.
> 
> This patch proposes to enhance the `JShell.diagnostics(Snippet)` with an ability to return best-effort diagnostics for these transient snippets.
> 
> Please also review the CSR:
> https://bugs.openjdk.org/browse/JDK-8341200

lgtm

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21261#pullrequestreview-2424000086