RFR: 8341495: JShell crashes with java.util.MissingFormatArgumentException [v5]

Archie Cobbs acobbs at openjdk.org
Fri Nov 8 16:15:38 UTC 2024


> JShell prints some of its output using `printf()` formatted strings. However, there are a few spots where a string `str` to be printed is passed directly as a format string like `format(str)` instead of indirectly like `format("%s", str)`, even though the string `str` contains unknown or arbitrary content outside of JShell's control. As a result, JShell can crash suddenly with a `MissingFormatArgumentException` or similar exception if the string `str` happens to contain a `%` format specifier, etc.
> 
> Please review this patch which attempts to fix the places where an unknown string is passed directly as a format string.

Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge branch 'master' into JDK-8341495
 - Rename another String parameter to "format" to reflect its purpose.
 - Revert previous change to unrelated JLine prompt substitution.
 - Use replace() instead of replaceAll() for literal string substitution.
 - Fix  prefixing/postfixing logic broken by previous commit.
 - Avoid invoking out.printf() with unknown format strings that might contain escapes.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21339/files
  - new: https://git.openjdk.org/jdk/pull/21339/files/4e692b45..70f053fa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21339&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21339&range=03-04

  Stats: 273069 lines in 3030 files changed: 170402 ins; 75142 del; 27525 mod
  Patch: https://git.openjdk.org/jdk/pull/21339.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21339/head:pull/21339

PR: https://git.openjdk.org/jdk/pull/21339


More information about the kulla-dev mailing list