RFR: 8343481: Remove unnecessary @SuppressWarnings annotations (kulla) [v5]

Jan Lahoda jlahoda at openjdk.org
Wed Nov 20 07:40:16 UTC 2024


On Tue, 19 Nov 2024 22:28:01 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> Question for @lahodaj ... I'm realizing now that most of the files patched here are imports from JLine.
> 
> Is it important to minimize changes to these imported files? If so I can revert the JLine changes in this patch; there would then only be two patched files in `jdk.jshell` remaining.
> 
> Thanks.

Yes, it would be preferable to not touch the JLine code here, unless there's a compelling reason to do so. Ideally, the changes could be contributed to JLine, and we would adopt them at some point as part of a JLine upgrade.

Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21855#issuecomment-2487738252


More information about the kulla-dev mailing list