RFR: 8356165: System.in in jshell replace supplementary characters with ?? [v3]

[Adam Sotona]

On Mon, 19 May 2025 13:10:11 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> We could do something like that, although I wrote it as I wrote it mostly because that's more clearly correct. Although the current tests probably cover all the cases, so with a bit of work, we probably could eliminate the (explicit) array completely.
>> 
>> Overall, on most places, it is usually not necessary to be too clever - the VM can optimize and eliminate allocations if needed.
>> 
>> I'll leave it up to Adam and/or Christian whether they would prefer a slightly more complex code with less (explicit/visible) allocation.
>
> FWIW, we could do this:
> https://github.com/lahodaj/jdk/commit/6a07648829ee8df263cf3fc1c55055fe45d4eb17

Readability of the code is my preference unless the performance is absolutely critical (not this case).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25079#discussion_r2095709647