hg: lambda/lambda/langtools: Add support for creating lambda/method references through indy calls
Maurizio Cimadamore
maurizio.cimadamore at oracle.com
Thu Aug 25 04:18:20 PDT 2011
On 13/08/11 06:29, Ali Ebrahimi wrote:
> Hi Maurizio,
>
> When reviewing this changeset i saw the flowing code pattern some
> places in LambdaToMethod.java:
>
> - LambdaTranslationContext localContext = context;
> + TranslationContext localContext = context;
> while (localContext != null) {
> + if (localContext.tree.getTag() !=
> JCTree.LAMBDA) continue;
>
> Is not this infinite loop? or localContext.tree.getTag() has side effect?
You are right - I forgot to update localContext in the branch.
Thanks for the headsup.
Maurizio
> Best Regards,
> Ali Ebrahimi
> On 8/8/11, maurizio.cimadamore at oracle.com
> <maurizio.cimadamore at oracle.com> wrote:
>> Changeset: 95ae37c3d0cf
>> Author: mcimadamore
>> Date: 2011-08-08 13:42 +0100
>> URL:
>> http://hg.openjdk.java.net/lambda/lambda/langtools/rev/95ae37c3d0cf
>>
>> Add support for creating lambda/method references through indy calls
>> *) Added code-generation support for BootstrapMethods attribute
>> *) Added code-generation support for CONSTANT_InvokeDynamic CP entry
>> *) Added simple bootstrap method used to create SAM instances (simply links
>> to the old method using dynamic proxies)
>> *) Added desugaring support for generating invokedynamic calls
>>
>> ! src/share/classes/com/sun/runtime/ProxyHelper.java
>> ! src/share/classes/com/sun/tools/javac/code/Symbol.java
>> ! src/share/classes/com/sun/tools/javac/code/Symtab.java
>> ! src/share/classes/com/sun/tools/javac/comp/Attr.java
>> ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
>> ! src/share/classes/com/sun/tools/javac/comp/LambdaTranslator.java
>> ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
>> ! src/share/classes/com/sun/tools/javac/jvm/Gen.java
>> ! src/share/classes/com/sun/tools/javac/jvm/Items.java
>> ! src/share/classes/com/sun/tools/javac/jvm/Pool.java
>> ! src/share/classes/com/sun/tools/javac/tree/JCTree.java
>> ! src/share/classes/com/sun/tools/javac/tree/Pretty.java
>> ! src/share/classes/com/sun/tools/javac/util/Names.java
>>
>>
>>
More information about the lambda-dev
mailing list