hg: lambda/lambda/jdk: Add BufferedReader.lines

Arne Siegel v.a.ammodytes at googlemail.com
Sun Nov 11 15:24:15 PST 2012


Hi Brian,

nice utility function, though I don't think you got the if statement in next() right.

@Override
public String next() {
    if (nextLine == null || hasNext()) {
        try {
            return nextLine;
...

Better keep it simple:
...
    if (hasNext()) {
...

Arne Siegel


On 11 Nov 2012 at 22:50, brian.goetz at oracle.com wrote:

> Changeset: 94d64473e8e6
> Author:    briangoetz
> Date:      2012-11-11 17:44 -0500
> URL:       http://hg.openjdk.java.net/lambda/lambda/jdk/rev/94d64473e8e6
> 
> Add BufferedReader.lines
> 
> ! src/share/classes/java/io/BufferedReader.java
> ! src/share/classes/java/io/Reader.java
> + src/share/classes/java/io/UncheckedIOException.java
> 
> 




More information about the lambda-dev mailing list