RFR: 8335358: [premain] Explore alternative ways to trigger the end of training run [v3]

[Ioi Lam]

On Thu, 12 Sep 2024 17:35:36 GMT, Mat Carter <macarte at openjdk.org> wrote:

>> Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   another missing include that impacts some build configurations
>
> src/hotspot/share/services/diagnosticCommand.hpp line 410:
> 
>> 408:     static const JavaPermission permission() {
>> 409:     JavaPermission p = {"java.lang.management.ManagementPermission",
>> 410:                         "monitor", nullptr};
> 
> Should this be 'monitor' or 'control' (or something else)?

I think "monitor" is appropriate (used also for dumping heap, etc). The API says "control" is to "control the runtime characteristics of the Java virtual machine", but we aren't really modifying the runtime characteristics.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/21#discussion_r1762272495