RFR: 8355352: [premain] rename AOT Code classes and logging tags

Vladimir Kozlov kvn at openjdk.org
Wed Apr 23 15:22:11 UTC 2025


On Wed, 23 Apr 2025 06:11:40 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Rename AOT Code classes and logging tags to match changes for mainline: [#24740](https://github.com/openjdk/jdk/pull/24740)
>> 
>> This is first part of changes in premain branch.  AOT code flags renaming and more code changes will be done in separate PRs.
>> 
>> Tested with premain-tier1
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 31:
> 
>> 29: #include "ci/ciUtilities.hpp"
>> 30: #include "code/compiledIC.hpp"
>> 31: #if INCLUDE_CDS
> 
> Did you mean to only remove `INCLUDE_CDS` , and add the `#include` for `autoCodeCache.hpp`?

`macroAssembler_aarch64.hpp` already has #include.

> src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp line 27:
> 
>> 25: #include "asm/macroAssembler.inline.hpp"
>> 26: #if INCLUDE_CDS
>> 27: #include "code/SCCache.hpp"
> 
> While you are at it, remove `INCLUDE_CDS` guards around includes like these?

Will do.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/60#discussion_r2056297291
PR Review Comment: https://git.openjdk.org/leyden/pull/60#discussion_r2056299667


More information about the leyden-dev mailing list