RFR: 8355352: [premain] rename AOT Code classes and logging tags

[Vladimir Kozlov]

On Wed, 23 Apr 2025 06:20:11 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Rename AOT Code classes and logging tags to match changes for mainline: [#24740](https://github.com/openjdk/jdk/pull/24740)
>> 
>> This is first part of changes in premain branch.  AOT code flags renaming and more code changes will be done in separate PRs.
>> 
>> Tested with premain-tier1
>
> src/hotspot/share/code/aotCodeCache.cpp line 4602:
> 
>> 4600:   if (!_extrs_complete) {
>> 4601:     fatal("AOT Code Cache VM runtime addresses table is not complete");
>> 4602:   }
> 
> We sure this move makes sense?

`id_for_address()` is called for processing relocation info in compiled code (stubs, adapters, code). We should not do that until we initialized the table for VM's runtime addresses at least! We do that initialization very early in `SCCache::init2()` which is called just after `universe_init()`.

> src/hotspot/share/compiler/compilationPolicy.cpp line 1094:
> 
>> 1092: 
>> 1093: bool CompilationPolicy::compare_tasks(CompileTask* x, CompileTask* y) {
>> 1094:   assert(!x->is_aot() && !y->is_aot(), "SC tasks are not expected here");
> 
> "AOT tasks are not expected here"?

Will fix.

> src/hotspot/share/compiler/compileBroker.cpp line 3201:
> 
>> 3199:   if (StoreCachedCode || LoadCachedCode) { // Check flags because SC cache could be closed already
>> 3200:     tty->cr();
>> 3201:     AOTCodeCache::print_timers_on(tty);
> 
> There is a mention of "SC cache" a few lines above.

Will fix

> src/hotspot/share/compiler/compileTask.cpp line 25:
> 
>> 23:  */
>> 24: 
>> 25: #include "code/SCCache.hpp"
> 
> This compilation unit uses `AOTCode*` stuff, so the include for `aotCodeCache.hpp` should be here?

The only reference is `AOTCodeEntry*`  which is declared in `compileTask.hpp`. No methods from it are called.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/60#discussion_r2056314073
PR Review Comment: https://git.openjdk.org/leyden/pull/60#discussion_r2056314589
PR Review Comment: https://git.openjdk.org/leyden/pull/60#discussion_r2056314941
PR Review Comment: https://git.openjdk.org/leyden/pull/60#discussion_r2056321010