RFR: 8355352: [premain] rename AOT Code classes and logging tags

Aleksey Shipilev shade at openjdk.org
Wed Apr 23 15:36:06 UTC 2025


On Wed, 23 Apr 2025 15:26:55 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> src/hotspot/share/code/aotCodeCache.cpp line 4602:
>> 
>>> 4600:   if (!_extrs_complete) {
>>> 4601:     fatal("AOT Code Cache VM runtime addresses table is not complete");
>>> 4602:   }
>> 
>> We sure this move makes sense?
>
> `id_for_address()` is called for processing relocation info in compiled code (stubs, adapters, code). We should not do that until we initialized the table for VM's runtime addresses at least! We do that initialization very early in `SCCache::init2()` which is called just after `universe_init()`.

OK!

>> src/hotspot/share/compiler/compileTask.cpp line 25:
>> 
>>> 23:  */
>>> 24: 
>>> 25: #include "code/SCCache.hpp"
>> 
>> This compilation unit uses `AOTCode*` stuff, so the include for `aotCodeCache.hpp` should be here?
>
> The only reference is `AOTCodeEntry*`  which is declared in `compileTask.hpp`. No methods from it are called.

Right, OK.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/60#discussion_r2056317987
PR Review Comment: https://git.openjdk.org/leyden/pull/60#discussion_r2056325545


More information about the leyden-dev mailing list