RFR: 8349457: [leyden] Workaround Leyden problems with -XX:-TieredCompilation [v3]
Aleksey Shipilev
shade at openjdk.org
Mon Feb 10 15:49:27 UTC 2025
On Mon, 10 Feb 2025 15:38:43 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:
>> Right, I thought it matters for Precompiler not to attempt pre-compiling C1 classes with `-XX:-TieredCompilation`, but it does not. I see `runtime/cds` passing with/without TieredCompilation without these hunks, and CDS archive sizes are similar, and performance is still the same. So I have reverted Precompiler hunks as unnecessary.
>>
>> Take a look again?
>
>> CDS archive sizes are similar,
>
> I think this would impact the code archive, not the CDS archive.
> If it does reduce the on-disk size of code archive, then why not do this? It's pretty straightforward; not a complicated change IMO.
I looked at both `.cds` and `.cds.code` files, and they are of similar size with `-XX:-TieredCompilation` whether we have this runtime check or not. I suspect this is because with `-XX:-TieredCompilation` we _do not have_ C1 compilations at all, so there is nothing to precompile. This makes the code change redundant.
-------------
PR Review Comment: https://git.openjdk.org/leyden/pull/32#discussion_r1949370691
More information about the leyden-dev
mailing list