RFR: 8349457: [leyden] Workaround Leyden problems with -XX:-TieredCompilation [v4]
Ashutosh Mehra
asmehra at openjdk.org
Mon Feb 10 16:45:23 UTC 2025
On Mon, 10 Feb 2025 15:46:51 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>>> CDS archive sizes are similar,
>>
>> I think this would impact the code archive, not the CDS archive.
>> If it does reduce the on-disk size of code archive, then why not do this? It's pretty straightforward; not a complicated change IMO.
>
> I looked at both `.cds` and `.cds.code` files, and they are of similar size with `-XX:-TieredCompilation` whether we have this runtime check or not. I suspect this is because with `-XX:-TieredCompilation` we _do not have_ C1 compilations at all, so there is nothing to precompile. This makes the code change redundant.
> I looked at both .cds and .cds.code files, and they are of similar size with -XX:-TieredCompilation whether we have this runtime check or not. I suspect this is because with -XX:-TieredCompilation we do not have C1 compilations at all, so there is nothing to precompile. This makes the code change redundant.
hmm ... I just tried your original patch with [quarkus-getting-started](https://github.com/openjdk/leyden/tree/premain/test/hotspot/jtreg/premain/quarkus-getting-started) test and see the size of `.cds.code` goes down from `4816316` to `1459860` and `.cds` came down from `38363136` to `36966400`
-------------
PR Review Comment: https://git.openjdk.org/leyden/pull/32#discussion_r1949496630
More information about the leyden-dev
mailing list