RFR: Store cpu features in AOTCodeCache header
Ashutosh Mehra
asmehra at openjdk.org
Tue Jul 29 13:41:22 UTC 2025
On Tue, 29 Jul 2025 13:24:31 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> I think I have missed changes for macos-aarch64 combination. I think I need to update `os_cpu/bsd_aarch64/vm_version_bsd_aarch64.cpp` for macos-aarch64, right @adinn @vnkozlov ?
>
>> I think I need to update os_cpu/bsd_aarch64/vm_version_bsd_aarch64.cpp for ?macos-aarch64, right
>
> Yes, there may well be things that need changing in bsd_aarch64 vm version code. However it assumes a lot of things fromthe (current) fact that this must be Apple silicon so things do not match that closely.
>
> Interesting that none of the macos gate tests failed even though you changed nothing in this file . . .
@adinn
> However it assumes a lot of things fromthe (current) fact that this must be Apple silicon so things do not match that closely.
I didn't follow your comment. Did you mean there is code that applies to Apple silicon but not to aarch64?
> Interesting that none of the macos gate tests failed even though you changed nothing in this file . . .
Yeah I am surprised I didn't get any failures to indicate the missing changes.
-------------
PR Comment: https://git.openjdk.org/leyden/pull/84#issuecomment-3132586759
More information about the leyden-dev
mailing list