RFR: Store cpu features in AOTCodeCache header

[Andrew Dinn]

On Tue, 29 Jul 2025 13:38:43 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>>> I think I need to update os_cpu/bsd_aarch64/vm_version_bsd_aarch64.cpp for ?macos-aarch64, right
>> 
>> Yes, there may well be things that need changing in bsd_aarch64 vm version code. However it assumes a lot of things fromthe (current) fact that this must be Apple silicon so things do not match that closely.
>> 
>> Interesting that none of the macos gate tests failed even though you changed nothing in this file . . .
>
> @adinn 
>> However it assumes a lot of things fromthe (current) fact that this must be Apple silicon so things do not match that closely.
> 
> I didn't follow your comment. Did you mean there is code that applies to Apple silicon but not to aarch64?
> 
>> Interesting that none of the macos gate tests failed even though you changed nothing in this file . . .
> 
> Yeah I am surprised I didn't get any failures to indicate the missing changes.

@ashu-mehra I was merely indicating that the changes you made in vm_version_linux_aarch64.cpp are not simply able to be reapplied to vm_version_bsd_aarch64.cpp because the latter file checks things very differently.

In particular, it bypasses a lot of the hardware checks on the assumption that this must be apple hardware (perhaps a questionable thing to rely on).

-------------

PR Comment: https://git.openjdk.org/leyden/pull/84#issuecomment-3132650061