RFR: Update nmethod caching and clean up unused/duplicate methods [v3]

Vladimir Kozlov kvn at openjdk.org
Wed Jun 4 00:13:39 UTC 2025


On Mon, 2 Jun 2025 14:51:47 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>> This PR updates nmethod caching to be based on caching of CodeBlob. It also cleans up some dead code and duplicate methods.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove CodeBuffer::clear_strings() as the relevant destructors clear the
>   strings
>   
>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>

Before I start testing and approve it I think we should wait your fix JDK-8358330 integration (my testing is still running) and then merge from mainline to premain.

src/hotspot/share/code/aotCodeCache.hpp line 107:

> 105: 
> 106:   uint   _blob_offset; // Start of archived blob in the cache
> 107:   uint   _code_offset; // Start of code for an entry of type "Stub"

Why you need 2 different fields for offset?

-------------

PR Comment: https://git.openjdk.org/leyden/pull/71#issuecomment-2937805951
PR Review Comment: https://git.openjdk.org/leyden/pull/71#discussion_r2125152991


More information about the leyden-dev mailing list