RFR: Update nmethod caching and clean up unused/duplicate methods [v3]
Ashutosh Mehra
asmehra at openjdk.org
Wed Jun 4 17:14:21 UTC 2025
On Wed, 4 Jun 2025 00:08:42 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove CodeBuffer::clear_strings() as the relevant destructors clear the
>> strings
>>
>> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> src/hotspot/share/code/aotCodeCache.hpp line 107:
>
>> 105:
>> 106: uint _blob_offset; // Start of archived blob in the cache
>> 107: uint _code_offset; // Start of code for an entry of type "Stub"
>
> Why you need 2 different fields for offset?
I did this only for the clarity - using `_blob_offset` is for storing Stubs doesn't sound correct, so I added `_code_offset` for the Stubs. If it is confusing, I can keep `_blob_offset` and remove the `_code_offset` field.
-------------
PR Review Comment: https://git.openjdk.org/leyden/pull/71#discussion_r2127073051
More information about the leyden-dev
mailing list