RFR: Update nmethod caching and clean up unused/duplicate methods [v3]
Vladimir Kozlov
kvn at openjdk.org
Wed Jun 4 23:20:17 UTC 2025
On Wed, 4 Jun 2025 17:11:05 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:
>> src/hotspot/share/code/aotCodeCache.hpp line 107:
>>
>>> 105:
>>> 106: uint _blob_offset; // Start of archived blob in the cache
>>> 107: uint _code_offset; // Start of code for an entry of type "Stub"
>>
>> Why you need 2 different fields for offset?
>
> I did this only for the clarity - using `_blob_offset` is for storing Stubs doesn't sound correct, so I added `_code_offset` for the Stubs. If it is confusing, I can keep `_blob_offset` and remove the `_code_offset` field.
I would suggest to use old `_code_ofset` for now. As we discussed on meeting we will need separate _metadata_offset to move all data describing code so we can map whole section of codes directly into CodeCache.
-------------
PR Review Comment: https://git.openjdk.org/leyden/pull/71#discussion_r2127582863
More information about the leyden-dev
mailing list