RFR: 8347755: Support static library in jmod [v4]

[Severin Gehwolf]

On Tue, 4 Mar 2025 16:23:36 GMT, Henry Jen <henryjen at openjdk.org> wrote:

>> This PR add --static-libs option to the jmod tool, it's basically mirroring --libs option to support adding a new section of static archive into the jmod file under the new section `static-lib`.
>> 
>> The JMOD magic header contains a MAJOR and MINOR version, we bump up the MINOR version if the --static-libs option is specified; otherwise, keep the MINOR version as 1. This allow created JMOD file without the newly supported static-lib section to continue be consumed by earlier version of jmod tool.
>> 
>> Also fix the formatting for _hermetic_jdk_jimage_offset, which is a julong(uint64_t) as unsigned long long on MacOS, thus need to use %llu.
>
> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   support major version validation

src/java.base/share/classes/jdk/internal/jmod/JmodFile.java line 195:

> 193:         } else {
> 194:             os.write(JMOD_MAGIC_NO_STATIC_LIB);
> 195:         }

This conditionality seems a bit strange. Isn't the idea for the magic to be changed when the format got extended to do more things? I.e. shouldn't this be micro version `0x01` in both cases? Then when dealing with version JMOD `1.1` version you'd be checking if static-libs is there.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/46#discussion_r1981396924