RFR: 8347755: Support static library in jmod [v4]

[Henry Jen]

On Wed, 5 Mar 2025 13:29:35 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   support major version validation
>
> src/java.base/share/classes/jdk/internal/jmod/JmodFile.java line 195:
> 
>> 193:         } else {
>> 194:             os.write(JMOD_MAGIC_NO_STATIC_LIB);
>> 195:         }
> 
> This conditionality seems a bit strange. Isn't the idea for the magic to be changed when the format got extended to do more things? I.e. shouldn't this be micro version `0x01` in both cases? Then when dealing with version JMOD `1.1` version you'd be checking if static-libs is there.

The idea is without static lib, it's essential the same as the old format, using the old version so that old tools can be used if static is not included.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/46#discussion_r1981636419