RFR: Some AOTCodeCache cleanup after merge from mainline [v2]

[Ashutosh Mehra]

On Wed, 14 May 2025 18:34:37 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> The test hit assert running CDS test on Windows. I attached hs_err_pid44896.log to [JDK-8354887](https://bugs.openjdk.org/browse/JDK-8354887) since this one does not have JBS entry.

I think this assert comes from:

uint AOTCacheAccess::delta_from_shared_address_base(address addr) {
  if (CDSConfig::is_dumping_final_static_archive()) {
    assert(ArchiveBuilder::is_active(), "must be");
    ArchiveBuilder* builder = ArchiveBuilder::current();
    address requested_addr = builder->to_requested(builder->get_buffered_addr(addr));
    return (uint)pointer_delta(requested_addr, (address)SharedBaseAddress, 1);
  } else {
    // Old CDS+AOT workflow.
    return (uint)pointer_delta(addr, (address)SharedBaseAddress, 1);
  }
} 

The error log file shows SharedBaseAddress is `0x000001ec04000000` which matches with the value printed by the assert.

-------------

PR Comment: https://git.openjdk.org/leyden/pull/66#issuecomment-2881216144